Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for macOS #11

Open
wjkaufman opened this issue Aug 7, 2020 · 10 comments
Open

Support for macOS #11

wjkaufman opened this issue Aug 7, 2020 · 10 comments
Labels
enhancement New feature or request

Comments

@wjkaufman
Copy link

I'm using macOS (Catalina Version 10.15.6) as my main development environment, and it would be great to use Reverb on this OS.

@alaterre
Copy link

Upvote this! I'm working on mac as well, I have a DockerFile but it's really not as easy to develop. Same for colab, great but it quickly reaches its limit.

@drozzy
Copy link

drozzy commented Aug 28, 2020

It would be great if this worked on mac (and even windows?), so that we could run acme on other OSes as well.
Thanks!

@tfboyd
Copy link
Collaborator

tfboyd commented Nov 6, 2020

Docker is your best bet. https://github.com/deepmind/reverb/tree/master/reverb/pip_package

There is a desire to support Mac, but we do not use it internally and finding resources to make it work and then setup the same level of testing vs. "hope" it does not break is not easy. I know not everyone likes Docker but I personally love it because it keeps everything in a nice container (ha ha) and I can move it anywhere with limited issues.

I also know this is frustrating. If someone got it working we likely would try to setup testing. This does come up about once a quarter at our planning meetings. If it was pure python, it would be easy.

@tfboyd tfboyd added the enhancement New feature or request label Nov 6, 2020
@lifeiteng lifeiteng mentioned this issue Nov 21, 2020
4 tasks
@lifeiteng
Copy link
Contributor

@alaterre I have made a pull request #24, can you help me verify it?

@tfboyd
Copy link
Collaborator

tfboyd commented Dec 1, 2020 via email

@lifeiteng
Copy link
Contributor

lifeiteng commented Jan 16, 2021

@wjkaufman you can try my branch #24

@wookayin
Copy link

wookayin commented Feb 3, 2023

The PR #24 is continued in #119.

@cemlyn007
Copy link

I have got the latest version of Reverb to compile for Mac x86_64 and arm64. I could do an MR if people are interested?

@cemlyn007
Copy link

Here you go #128

@engichang1467
Copy link

The package has now been published on PyPI as dm-reverb-macos. I would love to hear your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants