Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ./pkg/repo #335

Closed
arschles opened this issue Jul 26, 2018 · 1 comment
Closed

Clean up ./pkg/repo #335

arschles opened this issue Jul 26, 2018 · 1 comment
Assignees
Labels
proxy Work to do on the module proxy refactor work to do to refactor code

Comments

@arschles
Copy link
Member

arschles commented Jul 26, 2018

Now that #291 is in, all of the code in ./pkg/repo has been refactored for use in #290 and moved to ./pkg/module. This issue is for removing all of ./pkg/repo.

A lot of code up the stack relies on ./pkg/repo, so of course that code will need to be removed as well (see #312). Dependent code goes all the way up to asynchronous workers (also part of #290) and the proxy fetch handler, so all of that will need to be removed at once. We don't need to do all of that before we can consider #290 done, but this cleanup will get rid of a lot of code and will be 🎉

We should also use this opportunity to remove the gomod parser since I think the only places that use it are the aforementioned fetch route (if I'm wrong, let's keep it)

cc/ @marwan-at-work @robjloranger @marpio since we've all talked about this recently

@arschles arschles added refactor work to do to refactor code proxy Work to do on the module proxy labels Jul 26, 2018
@arschles arschles self-assigned this Jul 26, 2018
@arschles
Copy link
Member Author

arschles commented Jul 26, 2018

I'll take this one

(after #290 is done)

arschles added a commit to arschles/athens that referenced this issue Jul 28, 2018
arschles added a commit that referenced this issue Jul 30, 2018
* removing pkg/repo

Fixes #335

* removing the gomod parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy Work to do on the module proxy refactor work to do to refactor code
Projects
None yet
Development

No branches or pull requests

1 participant