feat: deprecate usage of linter alternative names #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
feat/deprecate-alt-names
branch
from
aed93f3 to
b6cec67
Compare
bombsimon
reviewed
Mar 24, 2024
bombsimon
reviewed
Mar 24, 2024
bombsimon
approved these changes
Mar 24, 2024
ccoVeille
reviewed
Mar 24, 2024
bombsimon
reviewed
Mar 24, 2024
alexandear
approved these changes
Mar 25, 2024
alexandear
reviewed
Mar 25, 2024
alexandear
reviewed
Mar 25, 2024
alexandear
reviewed
Mar 25, 2024
alexandear
reviewed
Mar 25, 2024
Antonboom
approved these changes
Mar 25, 2024
Co-authored-by: Simon Sawert <[email protected]>
Co-authored-by: Oleksandr Redko <[email protected]>
ldez
force-pushed
the
feat/deprecate-alt-names
branch
from
bdae2e5 to
44e0029
Compare
laurazard
added a commit
to laurazard/cli
that referenced
this pull request
Jul 25, 2024
`megacheck` has been deprecated/split into `gosimple`, `staticcheck`, and `unused`, which we're already using. https://github.com/golangci/golangci-lint/blob/d2b439faa53bc7d0645049c3e23fc858736b8cc4/pkg/lint/lintersdb/validator_test.go#L227 `vet` is now `govet`. https://github.com/golangci/golangci-lint/blame/d2b439faa53bc7d0645049c3e23fc858736b8cc4/pkg/lint/lintersdb/validator_test.go#L228 For more context, see: golangci/golangci-lint#4562 Signed-off-by: Laura Brehm <[email protected]>
laurazard
added a commit
to laurazard/cli
that referenced
this pull request
Jul 25, 2024
`megacheck` has been deprecated/split into `gosimple`, `staticcheck`, and `unused`, which we're already using. https://github.com/golangci/golangci-lint/blob/d2b439faa53bc7d0645049c3e23fc858736b8cc4/pkg/lint/lintersdb/validator_test.go#L227 `vet` is now `govet`. https://github.com/golangci/golangci-lint/blame/d2b439faa53bc7d0645049c3e23fc858736b8cc4/pkg/lint/lintersdb/validator_test.go#L228 For more context, see: golangci/golangci-lint#4562 Signed-off-by: Laura Brehm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays a warning when using alternative names.
I used the
Validatorbecause the linter names and alternative names are required for the analysis, then it cannot be done inside theLoader.FYI:
unused,gosimple,staticcheckcannot be merged as one "linter" because their requirements are completely different.Fixes #357
Related #3746