staticcheck: configuration for staticcheck, gosimple, stylecheck
#2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msugakov
added a commit
to stackrox/kube-linter
that referenced
this pull request
Sep 21, 2021
This one turned a bit more involved. Apparently, per golangci/golangci-lint#2017 staticcheck is split into four (!) linters under golangci-lit. These are: `staticcheck`, `gosimple`, `stylecheck` and `unused`. Using the same name `staticcheck` for one of linters is not confusing at all. Anyway, to get full staiccheck's power, one must enable all four linters in `.golangci.yml`. With that we can throw staticcheck target away from `Makefile`. Verified by omitting `"-ST1000"` in `stylecheck.checks` list and seeing how `make lint` fails with ST1000 findings. Unfortunately, I found no way to see log of each linter when it is executed in golangci-lint context to be able to confirm things more precisely. :-( Looks like golangci-lint simply does not support that.
msugakov
added a commit
to stackrox/kube-linter
that referenced
this pull request
Sep 21, 2021
This one turned a bit more involved. Apparently, per golangci/golangci-lint#2017 staticcheck is split into four (!) linters under golangci-lit. These are: `staticcheck`, `gosimple`, `stylecheck` and `unused`. Using the same name `staticcheck` for one of linters is not confusing at all. Anyway, to get full staiccheck's power, one must enable all four linters in `.golangci.yml`. With that we can throw staticcheck target away from `Makefile`. Verified by omitting `"-ST1000"` in `stylecheck.checks` list and seeing how `make lint` fails with ST1000 findings. Unfortunately, I found no way to see log of each linter when it is executed in golangci-lint context to be able to confirm things more precisely. :-( Looks like golangci-lint simply does not support that.
msugakov
added a commit
to stackrox/kube-linter
that referenced
this pull request
Sep 21, 2021
This one turned a bit more involved. Apparently, per golangci/golangci-lint#2017 staticcheck is split into four (!) linters under golangci-lit. These are: `staticcheck`, `gosimple`, `stylecheck` and `unused`. Using the same name `staticcheck` for one of linters is not confusing at all. Anyway, to get full staiccheck's power, one must enable all four linters in `.golangci.yml`. With that we can throw staticcheck target away from `Makefile`. Verified by omitting `"-ST1000"` in `stylecheck.checks` list and seeing how `make lint` fails with ST1000 findings. Unfortunately, I found no way to see log of each linter when it is executed in golangci-lint context to be able to confirm things more precisely. :-( Looks like golangci-lint simply does not support that.
SeigeC
pushed a commit
to SeigeC/golangci-lint
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1275
Staticcheck is split into 4 linters in golangci-lint
staticcheck,gosimple,stylecheckandunused.(more information: #1989 (comment))
staticcheckstylecheckgosimpleunusedgochecks(*)dot-import-whitelist(ST1003)initialisms(ST1001)http-status-code-whitelist(ST1013)(*): each
checkssection can only filter the rules related to this section:checksonstaticcheckonly filterSAxxxxruleschecksonstylecheckonly filterSTxxxxruleschecksongosimpleonly filterSxxxxrulesexample:
Staticcheck available options: https://staticcheck.io/docs/options