net/http: add ResponseController http2 request without body read deadline test #58282

AlexanderYastrebov · 2023-02-02T22:09:01Z

Requires CL 464936

gopherbot · 2023-02-02T22:16:56Z

This PR (HEAD: e950604) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/465035 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

komuw · 2023-02-03T05:24:41Z

src/net/http/responsecontroller_test.go

+	cst := newClientServerTest(t, http2Mode, HandlerFunc(func(w ResponseWriter, req *Request) {
+		ctl := NewResponseController(w)
+		if err := ctl.SetReadDeadline(time.Now().Add(1 * time.Millisecond)); err != nil {
+			t.Errorf("ctl.SetReadDeadline() = %v, want nil", err)
+		}
+		time.Sleep(10 * time.Millisecond)


since the 1ms and 10ms are related, my I suggest:

Suggested change

cst := newClientServerTest(t, http2Mode, HandlerFunc(func(w ResponseWriter, req *Request) {

ctl := NewResponseController(w)

if err := ctl.SetReadDeadline(time.Now().Add(1 * time.Millisecond)); err != nil {

t.Errorf("ctl.SetReadDeadline() = %v, want nil", err)

}

time.Sleep(10 * time.Millisecond)

cst := newClientServerTest(t, http2Mode, HandlerFunc(func(w ResponseWriter, req *Request) {

ctl := NewResponseController(w)

duration := 1 * time.Millisecond

if err := ctl.SetReadDeadline(time.Now().Add(duration)); err != nil {

t.Errorf("ctl.SetReadDeadline() = %v, want nil", err)

}

time.Sleep(10 * duration)

gopherbot · 2023-07-21T21:38:19Z

This PR (HEAD: 3e3a9aa) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/465035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-07T16:51:36Z

This PR (HEAD: a87c309) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/465035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-12T09:23:17Z

This PR (HEAD: 05965ef) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/465035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-20T21:59:29Z

Message from Damien Neil:

Patch Set 4: Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T22:06:29Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-20T21:53:50Z","revision":"d1d4256a142c3ea453627b73541385c5e55ffbb2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T22:06:30Z

Message from Damien Neil:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T22:06:31Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 465035)
tools on master (commit 3a915e4)

error: failed to run "test golang.org/x/tools module": exit status 1
failed to run "test golang.org/x/tools/gopls module": exit status 1

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T22:06:31Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T18:17:05Z

Message from Damien Neil:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

…line test Requires CL 464936 For golang#58237

gopherbot · 2023-11-22T09:21:31Z

This PR (HEAD: 30a1090) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/465035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-03-04T17:59:28Z

Message from Damien Neil:

Patch Set 5: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T17:59:29Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-04T17:54:43Z","revision":"e49f0b5dd1a64ebb25c64050aacb5dc4ff11f573"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T18:06:28Z

Message from Damien Neil:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T18:06:29Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 465035)
tools on master (commit 5bf7d00)

Error:
failed to run "test golang.org/x/tools/gopls module": exit status 1

Links:

"test golang.org/x/tools/gopls module" (combined output)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-04T18:06:30Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-05T23:02:10Z

Message from Damien Neil:

Patch Set 6: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-05T23:08:30Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-05T22:58:33Z","revision":"797f9ddff3ada5d2adf6ad9fb03c1bd9e2e68f6a"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-05T23:33:05Z

Message from Damien Neil:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-05T23:33:06Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-05T23:33:06Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-06T19:20:07Z

Message from Michael Knyszek:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/465035.
After addressing review feedback, remember to publish your drafts!

…line test Requires CL 464936 For #58237 Change-Id: I007b61f0f216d759f8e5327d77affbd9e8f8ff23 GitHub-Last-Rev: 30a1090 GitHub-Pull-Request: #58282 Reviewed-on: https://go-review.googlesource.com/c/go/+/465035 Reviewed-by: Damien Neil <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Knyszek <[email protected]>

gopherbot · 2024-03-06T19:26:40Z

This PR is being closed because golang.org/cl/465035 has been merged.

komuw reviewed Feb 3, 2023

View reviewed changes

AlexanderYastrebov force-pushed the go58237 branch from e950604 to 3e3a9aa Compare July 21, 2023 21:34

AlexanderYastrebov force-pushed the go58237 branch from 3e3a9aa to a87c309 Compare October 7, 2023 16:48

AlexanderYastrebov force-pushed the go58237 branch from a87c309 to 05965ef Compare October 12, 2023 09:21

net/http: add ResponseController http2 request without body read dead…

30a1090

…line test Requires CL 464936 For golang#58237

AlexanderYastrebov force-pushed the go58237 branch from 05965ef to 30a1090 Compare November 22, 2023 09:18

gopherbot closed this Mar 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net/http: add ResponseController http2 request without body read deadline test #58282

net/http: add ResponseController http2 request without body read deadline test #58282

AlexanderYastrebov commented Feb 2, 2023

gopherbot commented Feb 2, 2023

komuw Feb 3, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Oct 7, 2023

gopherbot commented Oct 12, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 22, 2023

gopherbot commented Mar 4, 2024

gopherbot commented Mar 4, 2024

gopherbot commented Mar 4, 2024

gopherbot commented Mar 4, 2024

gopherbot commented Mar 4, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 6, 2024

gopherbot commented Mar 6, 2024

net/http: add ResponseController http2 request without body read deadline test #58282

net/http: add ResponseController http2 request without body read deadline test #58282

Conversation

AlexanderYastrebov commented Feb 2, 2023

gopherbot commented Feb 2, 2023

komuw Feb 3, 2023

Choose a reason for hiding this comment

gopherbot commented Jul 21, 2023

gopherbot commented Oct 7, 2023

gopherbot commented Oct 12, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 22, 2023

gopherbot commented Mar 4, 2024

gopherbot commented Mar 4, 2024

gopherbot commented Mar 4, 2024

gopherbot commented Mar 4, 2024

gopherbot commented Mar 4, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 5, 2024

gopherbot commented Mar 6, 2024

gopherbot commented Mar 6, 2024