Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/asn1: add ability to marshal to general string #27579

Closed
wants to merge 2 commits into from

Conversation

jcmturner
Copy link

The current implementation cannot marshal a string into asn1 general
string encoded bytes. This capability has been added.

Fixes #18832

The current implementation cannot marshal a string into asn1 general
string encoded bytes. This capability has been added.

Fixes golang#18832
The current implementation cannot marshal a string into asn1 general
string encoded bytes. This capability has been added.

Fixes golang#18832
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 9, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 5137:

Patch Set 1: Run-TryBot+1

Thank you for the change Jonathan! I'll tag some experts here to help with review.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=428b579f


Please don’t reply on this GitHub thread. Visit golang.org/cl/134223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134223.
After addressing review feedback, remember to publish your drafts!

@t0rr3sp3dr0
Copy link

@bradfitz @odeke-em @agl @FiloSottile, can we move forward with this PR? It has been more than 4 years since the issue was first reported and it is still a problem on the latest version of Go.

I mentioned you because you are the reviewers assigned for this PR on Gerrit.

@heschi heschi closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encoding/asn1: cannot marshal into a GeneralString
5 participants