Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: timeouts in os/signal tests [1.11 backport] #27521

Closed
gopherbot opened this issue Sep 5, 2018 · 2 comments
Closed

runtime: timeouts in os/signal tests [1.11 backport] #27521

gopherbot opened this issue Sep 5, 2018 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.11.1

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #27520 to be considered for backport to the next 1.11 minor release.

@gopherbot, please open an issue for backport to 1.11.1.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 5, 2018
@gopherbot gopherbot mentioned this issue Sep 5, 2018
Closed
@gopherbot gopherbot added this to the Go1.11.1 milestone Sep 5, 2018
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/134096 mentions this issue: runtime: in semasleep, subtract time spent so far from timeout

@gopherbot
Copy link
Contributor Author

Closed by merging 5753489 to release-branch.go1.11.

gopherbot pushed a commit that referenced this issue Sep 7, 2018
@randall77 @ianlancetaylor
[release-branch.go1.11] runtime: in semasleep, subtract time spent so…
5753489 
… far from timeout

When pthread_cond_timedwait_relative_np gets a spurious wakeup
(due to a signal, typically), we used to retry with the same
relative timeout. That's incorrect, we should lower the timeout
by the time we've spent in this function so far.

In the worst case, signals come in and cause spurious wakeups
faster than the timeout, causing semasleep to never time out.

Also fix nacl and netbsd while we're here. They have similar issues.

Fixes #27521

Change-Id: I6601e120e44a4b8ef436eef75a1e7c8cf1d39e39
Reviewed-on: https://go-review.googlesource.com/133655
Run-TryBot: Keith Randall <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
(cherry picked from commit 2bf1370f4369d75f4fffffc6fc05722bce13481b)
Reviewed-on: https://go-review.googlesource.com/134096
@nvanbenschoten nvanbenschoten mentioned this issue Sep 10, 2018
Closed
@golang golang locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.11.1
Development

No branches or pull requests
1 participant
@gopherbot