This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
[WIP] write partial manifest upon init failure #1280
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
It writes out part of the manifest and lock if
dep init
fails during solve (and indicates in the manifest that it's incomplete). It's helpful because it gives the confused programmer something tangible to work from.What should your reviewer look out for in this PR?
Unintended side effects, proper idiomatic code. Some caveats are also listed in the list below.
Do you need help or clarification on anything?
What kind of tests ought to be written for this change?
Which issue(s) does this PR fix?
fixes #909
Comments on the state of the WIP (I wanted to get something up):
dep init
on a project that imports a project with an invalid manifest (one that contains version conflicts). The partial written manifest was empty, which I think caused more confusion. An upcoming commit will check for that, and won't bother writing the partial if it'll be empty.