Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the version of docker-compose to be installed in "build-package" #20907

Merged

Conversation

reasonerjt
Copy link
Contributor

@reasonerjt reasonerjt commented Sep 8, 2024

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@reasonerjt reasonerjt force-pushed the bump-up-base-img-1.10 branch 2 times, most recently from 388d17a to a0a5011 Compare September 8, 2024 04:42
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.04%. Comparing base (1788f8b) to head (3f5c642).
Report is 3 commits behind head on release-1.10.0.

❗ There is a different number of reports uploaded between BASE (1788f8b) and HEAD (3f5c642). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1788f8b) HEAD (3f5c642)
unittests 2 1
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.0   #20907      +/-   ##
==================================================
- Coverage           55.98%   50.04%   -5.94%     
==================================================
  Files                 612      155     -457     
  Lines               32466     6322   -26144     
  Branches              825      825              
==================================================
- Hits                18176     3164   -15012     
+ Misses              11491     2925    -8566     
+ Partials             2799      233    -2566     
Flag Coverage Δ
unittests 50.04% <ø> (-5.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 458 files with indirect coverage changes

@reasonerjt reasonerjt force-pushed the bump-up-base-img-1.10 branch from 3f5c642 to 8edc663 Compare September 8, 2024 07:12
@reasonerjt reasonerjt changed the title [DONT-MERGE]Debug docker-compose installation issue update the version of docker-compose to be installed in Sep 8, 2024
@reasonerjt reasonerjt changed the title update the version of docker-compose to be installed in update the version of docker-compose to be installed in "build-package" Sep 8, 2024
@reasonerjt reasonerjt added the release-note/ignore-for-release Do not include PR or Issue for release notes label Sep 8, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reasonerjt reasonerjt enabled auto-merge (squash) September 8, 2024 12:44
@reasonerjt reasonerjt merged commit 2b610f8 into goharbor:release-1.10.0 Sep 8, 2024
6 checks passed
@reasonerjt reasonerjt deleted the bump-up-base-img-1.10 branch December 13, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants