Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless error check for scan data export job #20883

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 28, 2024

Remove useless error check for scan data export job.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added release-note/update Update or Fix area/cve-export Related to cve export feature labels Aug 28, 2024
@chlins chlins requested a review from a team as a code owner August 28, 2024 03:06
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.29%. Comparing base (c8c11b4) to head (b32a79e).
Report is 268 commits behind head on main.

Files with missing lines Patch % Lines
...ervice/job/impl/scandataexport/scan_data_export.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20883       +/-   ##
===========================================
+ Coverage   45.36%   66.29%   +20.92%     
===========================================
  Files         244     1047      +803     
  Lines       13333   114251   +100918     
  Branches     2719     2847      +128     
===========================================
+ Hits         6049    75740    +69691     
- Misses       6983    34383    +27400     
- Partials      301     4128     +3827     
Flag Coverage Δ
unittests 66.29% <66.66%> (+20.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ervice/job/impl/scandataexport/scan_data_export.go 62.04% <66.66%> (ø)

... and 1286 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) August 30, 2024 03:26
@chlins chlins merged commit 9d11de9 into goharbor:main Aug 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cve-export Related to cve export feature release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants