Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the ui bug of banner coming over the search result container #20871

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fixed the ui bug of banner coming over the search result container #20871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/portal/src/app/shared/components/global-search/search-result.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="search-overlay" *ngIf="state">
<div [style.top.px]="getTopValue()" class="search-overlay" *ngIf="state">
<div id="placeholder1"></div>
<div class="search-header">
<a href="javascript:void(0)" (click)="close()"
Expand Down
7 changes: 7 additions & 0 deletions src/portal/src/app/shared/components/global-search/search-result.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,4 +176,11 @@ export class SearchResultComponent implements OnInit, OnDestroy {
}
);
}
getTopValue(): number {
const headerHeight: number =
document.querySelector('navigator')?.clientHeight || 0;
const bannerHeight: number =
document.querySelector('app-app-level-alerts')?.clientHeight || 0;
return headerHeight + bannerHeight;
}
}
1 change: 0 additions & 1 deletion src/portal/src/app/shared/components/global-search/search.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
z-index: 999;
box-sizing: border-box;
background: #fafafa;
top: 60px;
left: 0;
padding-left: 36px;
padding-right: 36px;
Expand Down
Loading