Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable audit log for robot #20843

Merged
merged 2 commits into from
Aug 14, 2024
Merged

enable audit log for robot #20843

merged 2 commits into from
Aug 14, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Aug 13, 2024

1, add creation audit log for robot account
2, add deletion audit log for robot account

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.28%. Comparing base (c8c11b4) to head (e4e6343).
Report is 260 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20843      +/-   ##
==========================================
+ Coverage   45.36%   46.28%   +0.91%     
==========================================
  Files         244      247       +3     
  Lines       13333    13779     +446     
  Branches     2719     2845     +126     
==========================================
+ Hits         6049     6377     +328     
- Misses       6983     7071      +88     
- Partials      301      331      +30     
Flag Coverage Δ
unittests 46.28% <ø> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

1, add creation audit log for robot account
2, add deletion audit log for robot account

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 merged commit 8ad8827 into goharbor:main Aug 14, 2024
12 checks passed
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
1, add creation audit log for robot account
2, add deletion audit log for robot account

Signed-off-by: wang yan <[email protected]>
Signed-off-by: kunal-511 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants