-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable audit log for robot #20843
Merged
Merged
enable audit log for robot #20843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20843 +/- ##
==========================================
+ Coverage 45.36% 46.28% +0.91%
==========================================
Files 244 247 +3
Lines 13333 13779 +446
Branches 2719 2845 +126
==========================================
+ Hits 6049 6377 +328
- Misses 6983 7071 +88
- Partials 301 331 +30
Flags with carried forward coverage won't be shown. Click here to find out more. |
wy65701436
force-pushed
the
robot-audit
branch
from
August 13, 2024 07:12
599abde
to
d4594bc
Compare
stonezdj
approved these changes
Aug 14, 2024
chlins
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
zyyw
reviewed
Aug 14, 2024
zyyw
approved these changes
Aug 14, 2024
1, add creation audit log for robot account 2, add deletion audit log for robot account Signed-off-by: wang yan <[email protected]>
wy65701436
force-pushed
the
robot-audit
branch
from
August 14, 2024 10:31
1d5bb2d
to
cf4e41f
Compare
kunal-511
pushed a commit
to kunal-511/harbor_local
that referenced
this pull request
Aug 22, 2024
1, add creation audit log for robot account 2, add deletion audit log for robot account Signed-off-by: wang yan <[email protected]> Signed-off-by: kunal-511 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, add creation audit log for robot account
2, add deletion audit log for robot account
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: