-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use internal registry url to push artifact accessory #20575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20575 +/- ##
==========================================
- Coverage 67.56% 66.24% -1.33%
==========================================
Files 991 1045 +54
Lines 109181 113481 +4300
Branches 2719 2845 +126
==========================================
+ Hits 73768 75173 +1405
- Misses 31449 34201 +2752
- Partials 3964 4107 +143
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
force-pushed
the
24jun11_remove_protocol_acc
branch
from
June 12, 2024 03:25
2815a64
to
23a474e
Compare
zyyw
approved these changes
Jun 12, 2024
wy65701436
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
stonezdj
force-pushed
the
24jun11_remove_protocol_acc
branch
5 times, most recently
from
June 14, 2024 07:22
eab22ab
to
0eeea91
Compare
fixes goharbor#20565 Signed-off-by: stonezdj <[email protected]>
stonezdj
force-pushed
the
24jun11_remove_protocol_acc
branch
from
June 14, 2024 07:33
0eeea91
to
12f6fcf
Compare
chlins
pushed a commit
to chlins/harbor
that referenced
this pull request
Jun 17, 2024
fixes goharbor#20565 Signed-off-by: stonezdj <[email protected]>
mohamedawnallah
pushed a commit
to mohamedawnallah/harbor
that referenced
this pull request
Jul 2, 2024
fixes goharbor#20565 Signed-off-by: stonezdj <[email protected]>
mohamedawnallah
pushed a commit
to mohamedawnallah/harbor
that referenced
this pull request
Jul 2, 2024
fixes goharbor#20565 Signed-off-by: stonezdj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20565
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: