Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal registry url to push artifact accessory #20575

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

stonezdj
Copy link
Contributor

fixes #20565

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner June 11, 2024 14:19
@stonezdj stonezdj added the release-note/update Update or Fix label Jun 11, 2024
@stonezdj stonezdj requested review from wy65701436 and zyyw June 11, 2024 14:20
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (b7b8847) to head (12f6fcf).
Report is 219 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20575      +/-   ##
==========================================
- Coverage   67.56%   66.24%   -1.33%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113481    +4300     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75173    +1405     
- Misses      31449    34201    +2752     
- Partials     3964     4107     +143     
Flag Coverage Δ
unittests 66.24% <100.00%> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/sbom/sbom.go 54.58% <100.00%> (ø)

... and 570 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24jun11_remove_protocol_acc branch from 2815a64 to 23a474e Compare June 12, 2024 03:25
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24jun11_remove_protocol_acc branch 5 times, most recently from eab22ab to 0eeea91 Compare June 14, 2024 07:22
@stonezdj stonezdj force-pushed the 24jun11_remove_protocol_acc branch from 0eeea91 to 12f6fcf Compare June 14, 2024 07:33
@stonezdj stonezdj merged commit e960711 into goharbor:main Jun 14, 2024
11 of 12 checks passed
chlins pushed a commit to chlins/harbor that referenced this pull request Jun 17, 2024
mohamedawnallah pushed a commit to mohamedawnallah/harbor that referenced this pull request Jul 2, 2024
mohamedawnallah pushed a commit to mohamedawnallah/harbor that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with SBOM generation in Harbor v2.11.0 when using external Reverse Proxy (HTTP 404)
5 participants