Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump up beego to v2.2.1 #20555

Merged
merged 1 commit into from
Jun 27, 2024
Merged

bump up beego to v2.2.1 #20555

merged 1 commit into from
Jun 27, 2024

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Jun 5, 2024 •
edited
Loading

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Upstream behavior change:

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/ignore-for-release Do not include PR or Issue for release notes label Jun 5, 2024
@MinerYang MinerYang requested a review from a team as a code owner June 5, 2024 08:37
@MinerYang MinerYang force-pushed the test_beego_v2.2.1 branch from cf2007b to 5871ac1 Compare June 5, 2024 08:38
@MinerYang MinerYang changed the title [DO NOT MERGE]test beego v2.2.1 test beego v2.2.1 Jun 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (b7b8847) to head (ce9c200).
Report is 232 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20555      +/-   ##
==========================================
- Coverage   67.56%   66.25%   -1.31%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113489    +4308     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75192    +1424     
- Misses      31449    34188    +2739     
- Partials     3964     4109     +145
Flag Coverage Δ
unittests 66.25% <100.00%> (-1.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/lib/orm/query.go 76.27% <100.00%> (+2.68%) ⬆️
src/pkg/artifact/dao/dao.go 57.34% <100.00%> (ø)
src/pkg/task/dao/execution.go 61.82% <100.00%> (+0.47%) ⬆️
src/pkg/task/dao/task.go 64.31% <100.00%> (+0.10%) ⬆️

... and 570 files with indirect coverage changes

@wy65701436 wy65701436 mentioned this pull request Jun 5, 2024
Closed
@MinerYang MinerYang force-pushed the test_beego_v2.2.1 branch from 6f85beb to d18eaf1 Compare June 6, 2024 02:27
@MinerYang MinerYang force-pushed the test_beego_v2.2.1 branch from d18eaf1 to b0f393a Compare June 6, 2024 13:26
@zyyw
Copy link
Contributor

zyyw commented Jun 7, 2024

@MinerYang please resolve the conflict.

@MinerYang MinerYang changed the title test beego v2.2.1 [Do not merge]test beego v2.2.1 Jun 11, 2024
@MinerYang MinerYang force-pushed the test_beego_v2.2.1 branch from b0f393a to cba7370 Compare June 11, 2024 03:15
Vad1mo
Vad1mo previously requested changes Jun 11, 2024
View reviewed changes
src/lib/orm/query.go Outdated Show resolved Hide resolved
@MinerYang MinerYang force-pushed the test_beego_v2.2.1 branch 2 times, most recently from da7b167 to 06ae5f4 Compare June 12, 2024 09:24
@MinerYang MinerYang force-pushed the test_beego_v2.2.1 branch 3 times, most recently from 0434a43 to 530bc33 Compare June 26, 2024 03:44
@MinerYang MinerYang changed the title [Do not merge]test beego v2.2.1 bump up beego to v2.2.1 Jun 26, 2024
wy65701436
wy65701436 reviewed Jun 26, 2024
View reviewed changes
src/lib/orm/query.go Outdated Show resolved Hide resolved
@MinerYang MinerYang force-pushed the test_beego_v2.2.1 branch from 530bc33 to 3daaaae Compare June 26, 2024 07:24
wy65701436
wy65701436 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang force-pushed the test_beego_v2.2.1 branch 3 times, most recently from b812e66 to 8c1daf8 Compare June 26, 2024 11:33
chlins
chlins approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang added release-note/update Update or Fix and removed release-note/ignore-for-release Do not include PR or Issue for release notes labels Jun 27, 2024
@MinerYang
test beego v2.2.1
ce9c200 
Signed-off-by: yminer <[email protected]>

update artifact dao count

update task dao count

update execution dao count

refactor disableSort option

using Option struct instead of const

remove comments

use option func

simplify
@MinerYang MinerYang force-pushed the test_beego_v2.2.1 branch from 8c1daf8 to ce9c200 Compare June 27, 2024 02:59
@MinerYang MinerYang enabled auto-merge (squash) June 27, 2024 06:37
@MinerYang MinerYang dismissed Vad1mo’s stale review June 27, 2024 06:38

Per yan's comment above, we will do the rector releated thing in an other PR

@MinerYang MinerYang merged commit 562c01e into goharbor:main Jun 27, 2024
11 of 12 checks passed
This was referenced Jul 17, 2024
Closed
Closed
@Vad1mo
Copy link
Member

Vad1mo commented Aug 15, 2024 •
edited
Loading

Supposes to fix #19401 and fix #20547

hajnalmt added a commit to hajnalmt/harbor that referenced this pull request Oct 3, 2024
@MinerYang @hajnalmt
[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)
eedb0b9 
bump up beego v2.2.1

Fix vulnerablities:
GHSA-wr3p-r5fj-wf97
GHSA-r6qh-j42j-pw64

Signed-off-by: yminer <[email protected]>
Co-authored-by: hajnalmt <[email protected]>
hajnalmt added a commit to hajnalmt/harbor that referenced this pull request Oct 3, 2024
@MinerYang @hajnalmt
[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)
fd59e9b 
bump up beego v2.2.1

Fix vulnerablities:
GHSA-wr3p-r5fj-wf97
GHSA-r6qh-j42j-pw64

Signed-off-by: yminer <[email protected]>
Co-authored-by: hajnalmt <[email protected]>
hajnalmt added a commit to hajnalmt/harbor that referenced this pull request Oct 3, 2024
@MinerYang @hajnalmt
[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)
4da6a6d 
bump up beego v2.2.1

Fix vulnerablities:
GHSA-wr3p-r5fj-wf97
GHSA-r6qh-j42j-pw64

Signed-off-by: yminer <[email protected]>
Co-authored-by: hajnalmt <[email protected]>
hajnalmt added a commit to hajnalmt/harbor that referenced this pull request Oct 3, 2024
@MinerYang @hajnalmt
[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)
a3e0a58 
bump up beego v2.2.1

Fix vulnerablities:
GHSA-wr3p-r5fj-wf97
GHSA-r6qh-j42j-pw64

Signed-off-by: yminer <[email protected]>
Co-authored-by: hajnalmt <[email protected]>
hajnalmt added a commit to hajnalmt/harbor that referenced this pull request Oct 4, 2024
@MinerYang @hajnalmt
[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)
12ac369 
bump up beego v2.2.1

Signed-off-by: yminer <[email protected]>
Co-authored-by: hajnalmt <[email protected]>
hajnalmt pushed a commit to hajnalmt/harbor that referenced this pull request Oct 4, 2024
@MinerYang @hajnalmt
[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)
5eb52cf 
bump up beego v2.2.1

Signed-off-by: hajnalmt <[email protected]>
Co-authored-by: yminer <[email protected]>
hajnalmt pushed a commit to hajnalmt/harbor that referenced this pull request Oct 4, 2024
@MinerYang @hajnalmt
[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)
6bbd3fe 
bump up beego v2.2.1

Co-authored-by: yminer <[email protected]>
Signed-off-by: Mate Hajnal <[email protected]>
reasonerjt pushed a commit that referenced this pull request Nov 13, 2024
@hajnalmt @MinerYang
[Cherrypick to v2.11] bump up beego to v2.2.1 (#20555) (#21000)
5d2b1ec 
bump up beego v2.2.1

Signed-off-by: Mate Hajnal <[email protected]>
Co-authored-by: MinerYang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vad1mo Vad1mo Vad1mo left review comments

@chlins chlins chlins approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@wy65701436 wy65701436

@chlins chlins

Labels
release-note/update Update or Fix target/2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MinerYang @zyyw @Vad1mo @wy65701436 @chlins @OrlinVasilev