Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes-20537 SBOM tab should not exist when the artifact is helm package #20539

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

xuelichao
Copy link
Contributor

Fixes-20537

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao xuelichao requested a review from a team as a code owner June 3, 2024 10:23
@xuelichao xuelichao added release-note/ignore-for-release Do not include PR or Issue for release notes target/2.11.0 labels Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@2b27170). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20539   +/-   ##
=================================================
  Coverage                  ?   66.23%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113494           
  Branches                  ?     2845           
=================================================
  Hits                      ?    75171           
  Misses                    ?    34213           
  Partials                  ?     4110           
Flag Coverage Δ
unittests 66.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@zyyw zyyw merged commit 81fcc0a into goharbor:release-2.11.0 Jun 3, 2024
12 checks passed
@zyyw zyyw added area/ui area/SBOM release-note/update Update or Fix and removed release-note/ignore-for-release Do not include PR or Issue for release notes labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants