Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] No sbom_overview when sbom is deleted #20534

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jun 3, 2024

fixes #20529

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner June 3, 2024 02:59
@stonezdj stonezdj requested a review from wy65701436 June 3, 2024 02:59
@stonezdj stonezdj requested a review from zyyw June 3, 2024 02:59
@stonezdj stonezdj assigned zyyw and unassigned Vad1mo, OrlinVasilev and AllForNothing Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@9944059). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20534   +/-   ##
=================================================
  Coverage                  ?   66.23%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113492           
  Branches                  ?     2844           
=================================================
  Hits                      ?    75173           
  Misses                    ?    34210           
  Partials                  ?     4109           
Flag Coverage Δ
unittests 66.23% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/server/v2.0/handler/assembler/report.go 50.64% <100.00%> (ø)

@stonezdj stonezdj requested a review from MinerYang June 3, 2024 03:14
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 2b27170 into goharbor:release-2.11.0 Jun 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants