Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix 20518 #20522

Merged
merged 1 commit into from
May 30, 2024

Conversation

wy65701436
Copy link
Contributor

fixes #20518
Since there is no report for the replicated artifact, update to use the artifact id to remove accessories.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fixes goharbor#20518
Since there is no report for the replicated artifact, update to use the artifact id to remove accessories.

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 changed the title fix 20518 [cherry-pick] fix 20518 May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-2.11.0@7c18987). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20522   +/-   ##
=================================================
  Coverage                  ?   66.25%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113483           
  Branches                  ?     2844           
=================================================
  Hits                      ?    75187           
  Misses                    ?    34186           
  Partials                  ?     4110           
Flag Coverage Δ
unittests 66.25% <36.36%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/sbom/sbom.go 52.25% <36.36%> (ø)

@zyyw zyyw merged commit 9944059 into goharbor:release-2.11.0 May 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants