Make it possible to build the spectral image also on ARM #20506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on ARM architecture.
Vad1mo
added
the
release-note/enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20506 +/- ##
===========================================
+ Coverage 45.36% 66.70% +21.33%
===========================================
Files 244 1047 +803
Lines 13333 114302 +100969
Branches 2719 2850 +131
===========================================
+ Hits 6049 76245 +70196
- Misses 6983 34164 +27181
- Partials 301 3893 +3592
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Vadim Bauer <[email protected]>
Signed-off-by: Vadim Bauer <[email protected]>
Vad1mo
force-pushed
the
fix/build_spectral_on_arm
branch
from
81db8f1 to
65ccf4a
Compare
Signed-off-by: Vadim Bauer <[email protected]>
|
as for ARM support, can we have a overall solution rather than just updating the spectral individually? |
5 tasks
|
@Vad1mo Please rebase the main branch, then we can merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local image build for ARM CPU Architecture
This change makes it possible to build the spectra image not only for the x86 architecture but also for ARM.
This also updates SPECTRAL_VERSION to 6.11.1 because 6.1 does not provide binaries apart from x86.
The main problem this fix solves is that users can better develop and compile Harbor locally on ARM systems.
Issue being resolved
Fixes various issues on building and running Harbor locally on ARM
https://github.com/goharbor/harbor/issues?q=is%3Aissue+ARM
Please indicate you've done the following: