Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize execution Manager in Report Assembler #20437

Merged
merged 1 commit into from
May 16, 2024

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner May 16, 2024 06:18
@stonezdj stonezdj requested a review from wy65701436 May 16, 2024 06:19
@stonezdj stonezdj requested a review from zyyw May 16, 2024 06:19
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.34%. Comparing base (b7b8847) to head (23b5a2c).
Report is 190 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20437      +/-   ##
==========================================
- Coverage   67.56%   66.34%   -1.22%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113165    +3984     
  Branches     2719     2830     +111     
==========================================
+ Hits        73768    75082    +1314     
- Misses      31449    34020    +2571     
- Partials     3964     4063      +99     
Flag Coverage Δ
unittests 66.34% <0.00%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/server/v2.0/handler/assembler/report.go 71.42% <0.00%> (ø)

... and 567 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24may16_fix_merge_issue branch from e94a24a to 23b5a2c Compare May 16, 2024 07:31
@stonezdj stonezdj merged commit 8ccf98a into goharbor:main May 16, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants