Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display status in sbom_overview for image index #20425

Merged
merged 1 commit into from
May 15, 2024

Conversation

stonezdj
Copy link
Contributor

fixes #20418

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.38%. Comparing base (b7b8847) to head (5841b7c).
Report is 187 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20425       +/-   ##
===========================================
- Coverage   67.56%   46.38%   -21.19%     
===========================================
  Files         991      247      -744     
  Lines      109181    13749    -95432     
  Branches     2719     2830      +111     
===========================================
- Hits        73768     6377    -67391     
+ Misses      31449     7047    -24402     
+ Partials     3964      325     -3639     
Flag Coverage Δ
unittests 46.38% <ø> (-21.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24may13_render_sbom_status branch from 1f0e21b to c1df7db Compare May 14, 2024 13:12
@zyyw zyyw mentioned this pull request May 15, 2024
5 tasks
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24may13_render_sbom_status branch from c1df7db to 5841b7c Compare May 15, 2024 11:16
@stonezdj stonezdj enabled auto-merge (squash) May 15, 2024 11:38
@stonezdj stonezdj merged commit df5b361 into goharbor:main May 15, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the image index's scan status when the child artifact is complete
5 participants