Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log and skip adapter ping error when retrieve adapter capability #20314

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner April 22, 2024 05:44
@stonezdj stonezdj added the release-note/update Update or Fix label Apr 22, 2024
@stonezdj stonezdj force-pushed the 24apr22_fix_outside_scanner branch from 5a22578 to 40dc8ad Compare April 22, 2024 05:48
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 69.11%. Comparing base (b7b8847) to head (430aac3).
Report is 152 commits behind head on main.

❗ Current head 430aac3 differs from pull request most recent head ee7535a. Consider uploading reports for the commit ee7535a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20314      +/-   ##
==========================================
+ Coverage   67.56%   69.11%   +1.54%     
==========================================
  Files         991      795     -196     
  Lines      109181    99190    -9991     
  Branches     2719        0    -2719     
==========================================
- Hits        73768    68553    -5215     
+ Misses      31449    26910    -4539     
+ Partials     3964     3727     -237     
Flag Coverage Δ
unittests 69.11% <33.33%> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/server/v2.0/handler/project.go 5.84% <60.00%> (+0.12%) ⬆️
src/controller/scanner/base_controller.go 36.86% <14.28%> (-1.10%) ⬇️

... and 317 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24apr22_fix_outside_scanner branch 3 times, most recently from f302bee to 4a86708 Compare April 22, 2024 06:40
@stonezdj stonezdj enabled auto-merge (squash) April 22, 2024 06:42
@stonezdj stonezdj force-pushed the 24apr22_fix_outside_scanner branch 2 times, most recently from 2a6b1cb to 430aac3 Compare April 22, 2024 09:00
@stonezdj stonezdj force-pushed the 24apr22_fix_outside_scanner branch from 430aac3 to ee7535a Compare April 22, 2024 09:07
@stonezdj stonezdj merged commit b7d4bf0 into goharbor:main Apr 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants