-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default capability for old scanners #20306
Set default capability for old scanners #20306
Conversation
Signed-off-by: stonezdj <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20306 +/- ##
==========================================
- Coverage 67.56% 66.34% -1.22%
==========================================
Files 991 1042 +51
Lines 109181 112941 +3760
Branches 2719 2827 +108
==========================================
+ Hits 73768 74932 +1164
- Misses 31449 33954 +2505
- Partials 3964 4055 +91
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
if c.Type == ScanTypeVulnerability { | ||
capabilities[supportVulnerability] = true | ||
} | ||
if c.Type == ScanTypeSbom { | ||
} else if c.Type == ScanTypeSbom { | ||
capabilities[supportSBOM] = true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch ... case
instead of if ... else if
?
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: