Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GenAccessoryArt API to generate valid accessory for SBOM #20214

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Apr 2, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner April 2, 2024 09:49
@stonezdj stonezdj added the release-note/update Update or Fix label Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.35%. Comparing base (b7b8847) to head (06def01).
Report is 110 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20214       +/-   ##
===========================================
- Coverage   67.56%   45.35%   -22.22%     
===========================================
  Files         991      244      -747     
  Lines      109181    13345    -95836     
  Branches     2719     2724        +5     
===========================================
- Hits        73768     6052    -67716     
+ Misses      31449     6991    -24458     
+ Partials     3964      302     -3662     
Flag Coverage Δ
unittests 45.35% <ø> (-22.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1235 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vad1mo Vad1mo enabled auto-merge (squash) April 2, 2024 20:59
@stonezdj stonezdj force-pushed the 24apr02_fix_gen_accessory branch from 329e2fa to 06def01 Compare April 3, 2024 07:21
@Vad1mo Vad1mo merged commit b6366e0 into goharbor:main Apr 3, 2024
11 of 12 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Apr 9, 2024
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants