Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated internationalisation : fr-fr #20179

Merged
merged 19 commits into from
Apr 10, 2024
Merged

Updated internationalisation : fr-fr #20179

merged 19 commits into from
Apr 10, 2024

Conversation

tostt
Copy link
Contributor

@tostt tostt commented Mar 27, 2024

Comprehensive Summary of your change

Edited file fr-fr-lang.json:

  • Translated strings into French

Due to the nature of the changes, no build or test of the application was performed.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@tostt tostt requested a review from a team as a code owner March 27, 2024 15:26
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (b7b8847) to head (a4f58a8).
Report is 123 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20179      +/-   ##
==========================================
+ Coverage   67.56%   67.59%   +0.02%     
==========================================
  Files         991     1002      +11     
  Lines      109181   110463    +1282     
  Branches     2719     2781      +62     
==========================================
+ Hits        73768    74665     +897     
- Misses      31449    31786     +337     
- Partials     3964     4012      +48     
Flag Coverage Δ
unittests 67.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 517 files with indirect coverage changes

@wy65701436 wy65701436 added release-note/update Update or Fix area/i18n Related to Translation changes. labels Mar 28, 2024
@Vad1mo Vad1mo enabled auto-merge (squash) March 28, 2024 07:38
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Show resolved Hide resolved
auto-merge was automatically disabled March 28, 2024 14:56

Head branch was pushed to by a user without write access

tostt and others added 2 commits March 28, 2024 15:56
Co-authored-by: Florian Blampey <[email protected]>
Signed-off-by: tostt <[email protected]>
Co-authored-by: Florian Blampey <[email protected]>
Signed-off-by: tostt <[email protected]>
Copy link
Contributor

@thcdrt thcdrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thank you for your contribution, here are some suggestions

src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
"FINISH": "Fin",
"BASIC_INFO": "Informations de base",
"SELECT_PERMISSIONS": "Selectionnez les permissions",
"SELECT_SYSTEM_PERMISSIONS": "Selectionnez les permissions système",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we conjugate this or should it be infinitive ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for 2 lines around

Copy link
Contributor Author

@tostt tostt Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed that to the infinitive.

src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
@tostt tostt requested a review from thcdrt April 8, 2024 13:44
@wy65701436
Copy link
Contributor

thanks @tostt @thcdrt for your contributions, I will merge this Pr and ship it with v2.11

@wy65701436 wy65701436 merged commit a858fb4 into goharbor:main Apr 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/i18n Related to Translation changes. release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants