-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated internationalisation : fr-fr #20179
Conversation
Signed-off-by: tostt <[email protected]>
Signed-off-by: tostt <[email protected]>
Signed-off-by: tostt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20179 +/- ##
==========================================
+ Coverage 67.56% 67.59% +0.02%
==========================================
Files 991 1002 +11
Lines 109181 110463 +1282
Branches 2719 2781 +62
==========================================
+ Hits 73768 74665 +897
- Misses 31449 31786 +337
- Partials 3964 4012 +48
Flags with carried forward coverage won't be shown. Click here to find out more. |
Head branch was pushed to by a user without write access
Co-authored-by: Florian Blampey <[email protected]> Signed-off-by: tostt <[email protected]>
Co-authored-by: Florian Blampey <[email protected]> Signed-off-by: tostt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Thank you for your contribution, here are some suggestions
"FINISH": "Fin", | ||
"BASIC_INFO": "Informations de base", | ||
"SELECT_PERMISSIONS": "Selectionnez les permissions", | ||
"SELECT_SYSTEM_PERMISSIONS": "Selectionnez les permissions système", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we conjugate this or should it be infinitive ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for 2 lines around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed that to the infinitive.
Co-authored-by: Thomas Coudert <[email protected]> Signed-off-by: tostt <[email protected]>
Co-authored-by: Thomas Coudert <[email protected]> Signed-off-by: tostt <[email protected]>
Co-authored-by: Thomas Coudert <[email protected]> Signed-off-by: tostt <[email protected]>
Co-authored-by: Thomas Coudert <[email protected]> Signed-off-by: tostt <[email protected]>
Co-authored-by: Thomas Coudert <[email protected]> Signed-off-by: tostt <[email protected]>
Co-authored-by: Thomas Coudert <[email protected]> Signed-off-by: tostt <[email protected]>
Signed-off-by: tostt <[email protected]>
Co-authored-by: Thomas Coudert <[email protected]> Signed-off-by: tostt <[email protected]>
Signed-off-by: tostt <[email protected]>
Signed-off-by: tostt <[email protected]>
Comprehensive Summary of your change
Edited file
fr-fr-lang.json
:Due to the nature of the changes, no build or test of the application was performed.
Please indicate you've done the following: