Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go.mod dep, golangci-lint, mocks #20121

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Mar 13, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Shengwen Yu added 4 commits March 11, 2024 10:56
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (b755416) to head (35db287).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2.10.0   #20121       +/-   ##
===================================================
- Coverage           67.53%   45.30%   -22.24%     
===================================================
  Files                 991      244      -747     
  Lines              109189    13333    -95856     
  Branches             2719     2719               
===================================================
- Hits                73740     6040    -67700     
+ Misses              31482     6991    -24491     
+ Partials             3967      302     -3665     
Flag Coverage Δ
unittests 45.30% <ø> (-22.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 750 files with indirect coverage changes

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 4ecc60d into goharbor:release-2.10.0 Mar 13, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants