Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Move strong_ssl_ciphers to top level in harbor.yaml #20022

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Feb 23, 2024

fixes #19912

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner February 23, 2024 07:47
@stonezdj stonezdj changed the title Move strong_ssl_ciphers to top level in harbor.yaml [cherry-pick] Move strong_ssl_ciphers to top level in harbor.yaml Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base (d55ed25) to head (f485d57).
Report is 1 commits behind head on release-2.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.10.0   #20022      +/-   ##
==================================================
- Coverage           67.54%   67.53%   -0.02%     
==================================================
  Files                 991      991              
  Lines              109181   109181              
  Branches             2719     2719              
==================================================
- Hits                73748    73736      -12     
- Misses              31465    31477      +12     
  Partials             3968     3968              
Flag Coverage Δ
unittests 67.53% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 2.10_fix_ssl_cipher branch from b805c59 to f485d57 Compare February 26, 2024 05:15
@stonezdj stonezdj enabled auto-merge (squash) February 26, 2024 05:29
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit b755416 into goharbor:release-2.10.0 Feb 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants