Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Cache image list with digest key #19838

Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jan 12, 2024

fixes #19429

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner January 12, 2024 06:32
@stonezdj stonezdj changed the title Cache image list with digest key [cherry-pick] Cache image list with digest key Jan 12, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4f19f84) 67.55% compared to head (1e1b9ca) 67.52%.
Report is 6 commits behind head on release-2.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.10.0   #19838      +/-   ##
==================================================
- Coverage           67.55%   67.52%   -0.03%     
==================================================
  Files                 991      991              
  Lines              109175   109181       +6     
  Branches             2719     2719              
==================================================
- Hits                73748    73728      -20     
- Misses              31458    31485      +27     
+ Partials             3969     3968       -1     
Flag Coverage Δ
unittests 67.52% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/proxy/controller.go 15.59% <50.00%> (-0.26%) ⬇️
src/controller/proxy/manifestcache.go 26.27% <0.00%> (-0.59%) ⬇️

... and 6 files with indirect coverage changes

@stonezdj stonezdj merged commit 773931d into goharbor:release-2.10.0 Jan 12, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants