Add verification that robot account duration is not 0 #19829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #19829 +/- ##
=======================================
Coverage 67.54% 67.55%
=======================================
Files 991 991
Lines 109171 109170 -1
Branches 2719 2719
=======================================
+ Hits 73739 73745 +6
+ Misses 31467 31459 -8
- Partials 3965 3966 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
approved these changes
Jan 11, 2024
YangJiao0817
force-pushed
the
fix-robot-duration
branch
6 times, most recently
from
1a9769a to
5b99b00
Compare
Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817
force-pushed
the
fix-robot-duration
branch
from
5b99b00 to
e4e5236
Compare
wy65701436
reviewed
Jan 15, 2024
| @@ -375,7 +374,7 @@ func isValidLevel(l string) bool { | |||
| } | |||
|
|
|||
| func isValidDuration(d int64) bool { | |||
| return d >= int64(-1) && d < math.MaxInt32 | |||
| return d >= int64(-1) && d != 0 && d < math.MaxInt32 | |||
There was a problem hiding this comment.
d == -1 || (d > 0 && d <= math.MaxInt32)
is more readable?
Vad1mo
pushed a commit
that referenced
this pull request
Jan 26, 2024
* registryctl/api/registry/blob: fix dropped test error (#19721) Signed-off-by: Lars Lehtonen <[email protected]> * Remove robot account update quota permission (#19819) Signed-off-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]> * Cache image list with digest key (#19801) fixes #19429 Signed-off-by: stonezdj <[email protected]> Co-authored-by: stonezdj <[email protected]> * Add quota permissions testcase (#19822) Signed-off-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]> * deprecate gosec in makefile (#19828) remove the unused the part from makefile Signed-off-by: wang yan <[email protected]> * Add verification that robot account duration is not 0 (#19829) Signed-off-by: Yang Jiao <[email protected]> * fix artifact page bug (#19807) * fix artifact page bug * update testcase * Upgrade to distribution (registry) v3 alpha This includes all the benefits of the v3 distribution, but also all breaking changes. Most notably, Image Manifest v2 Schema v1 support has been dropped, as well as the `oss` and `swift` storage drivers. Currently, this still relies on v2's github.com/docker/distribution/registry/client/auth/challenge, because that code has been removed from the public API in v3. Signed-off-by: Aaron Dewes <[email protected]> --------- Signed-off-by: Lars Lehtonen <[email protected]> Signed-off-by: Yang Jiao <[email protected]> Signed-off-by: stonezdj <[email protected]> Signed-off-by: wang yan <[email protected]> Signed-off-by: Aaron Dewes <[email protected]> Co-authored-by: Lars Lehtonen <[email protected]> Co-authored-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]> Co-authored-by: stonezdj(Daojun Zhang) <[email protected]> Co-authored-by: stonezdj <[email protected]> Co-authored-by: Wang Yan <[email protected]> Co-authored-by: ShengqiWang <[email protected]>
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Yang Jiao <[email protected]> Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #19794
Please indicate you've done the following: