Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add quota permissions testcase #19823

Conversation

YangJiao0817
Copy link
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (241b417) 67.54% compared to head (96b7853) 45.24%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2.10.0   #19823       +/-   ##
===================================================
- Coverage           67.54%   45.24%   -22.31%     
===================================================
  Files                 991      244      -747     
  Lines              109175    13332    -95843     
  Branches             2719     2719               
===================================================
- Hits                73745     6032    -67713     
+ Misses              31462     6998    -24464     
+ Partials             3968      302     -3666     
Flag Coverage Δ
unittests 45.24% <ø> (-22.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 751 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 disabled auto-merge January 11, 2024 06:39
@YangJiao0817 YangJiao0817 force-pushed the add-quota-api-permission-testcase-2.10 branch from 1d50157 to 96b7853 Compare January 11, 2024 08:07
@YangJiao0817 YangJiao0817 merged commit 8cecf2e into goharbor:release-2.10.0 Jan 12, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants