Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update project-SelectScanner modal Default field css #19753

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

ShengqiWang
Copy link
Contributor

@ShengqiWang ShengqiWang commented Dec 22, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19646

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d157f2) 67.54% compared to head (38c80b3) 67.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19753      +/-   ##
==========================================
+ Coverage   67.54%   67.55%   +0.01%     
==========================================
  Files         991      991              
  Lines      109165   109165              
  Branches     2719     2719              
==========================================
+ Hits        73734    73747      +13     
+ Misses      31462    31454       -8     
+ Partials     3969     3964       -5     
Flag Coverage Δ
unittests 67.55% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@MinerYang MinerYang added the release-note/update Update or Fix label Dec 22, 2023
@xuelichao xuelichao self-requested a review January 2, 2024 02:10
Copy link
Contributor

@xuelichao xuelichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShengqiWang ShengqiWang enabled auto-merge (squash) January 4, 2024 02:23
@ShengqiWang ShengqiWang merged commit ed4587b into goharbor:main Jan 4, 2024
12 checks passed
@ShengqiWang ShengqiWang deleted the issue_19646 branch January 4, 2024 02:24
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect default field CSS when selecting a scanner
5 participants