Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description in scanner page #19733

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

ShengqiWang
Copy link
Contributor

@ShengqiWang ShengqiWang commented Dec 19, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19647

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49ee3b7) 67.56% compared to head (2c43697) 67.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19733      +/-   ##
==========================================
- Coverage   67.56%   67.55%   -0.01%     
==========================================
  Files         991      991              
  Lines      109167   109167              
  Branches     2719     2719              
==========================================
- Hits        73755    73747       -8     
- Misses      31447    31455       +8     
  Partials     3965     3965              
Flag Coverage Δ
unittests 67.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@xuelichao xuelichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI part looks good to me

@yanji09 yanji09 assigned stonezdj and unassigned AllForNothing and chlins Dec 21, 2023
@stonezdj stonezdj merged commit 923295c into goharbor:main Dec 21, 2023
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Signed-off-by: shengqiw <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Description field to scanners page
7 participants