-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cherry-pick] disable external redis using acl username auth on release-2.8.0 #18894
[cherry-pick] disable external redis using acl username auth on release-2.8.0 #18894
Conversation
…ame auth Signed-off-by: yminer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-2.8.0 #18894 +/- ##
=================================================
+ Coverage 67.39% 70.52% +3.13%
=================================================
Files 984 749 -235
Lines 107025 93936 -13089
Branches 2670 0 -2670
=================================================
- Hits 72125 66251 -5874
+ Misses 31017 24100 -6917
+ Partials 3883 3585 -298
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't merge
we don't need this, since could bypass this issue by follow this FAQ |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Note: distribution configuration (until v2.8.2) only support auth by password
Issue being fixed
Fixes
Please indicate you've done the following: