Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] disable external redis using acl username auth on release-2.8.0 #18894

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Jul 5, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Note: distribution configuration (until v2.8.2) only support auth by password

Issue being fixed

Fixes

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Jul 5, 2023
@MinerYang MinerYang requested a review from a team as a code owner July 5, 2023 09:19
@MinerYang MinerYang changed the title [cherry-pick] [fix issue-18892]disable external redis using acl usern… [cherry-pick] disable external redis using acl username auth on release-2.8.0 Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #18894 (d61770a) into release-2.8.0 (f8282a5) will increase coverage by 3.13%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #18894      +/-   ##
=================================================
+ Coverage          67.39%   70.52%   +3.13%     
=================================================
  Files                984      749     -235     
  Lines             107025    93936   -13089     
  Branches            2670        0    -2670     
=================================================
- Hits               72125    66251    -5874     
+ Misses             31017    24100    -6917     
+ Partials            3883     3585     -298     
Flag Coverage Δ
unittests 70.52% <ø> (+3.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 240 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't merge

@MinerYang
Copy link
Contributor Author

we don't need this, since could bypass this issue by follow this FAQ

@MinerYang MinerYang closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants