chore: separate gc and convert #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desiki-high
changed the title
Desiki-high
force-pushed
the
separate-gc-convert
branch
from
9a169af to
15ae032
Compare
imeoer
reviewed
Sep 5, 2023
Desiki-high
force-pushed
the
separate-gc-convert
branch
2 times, most recently
from
45ca328 to
664b67d
Compare
- GC doesn't return any error, change to the error log. - Change gc call to ```goroutine```. Signed-off-by: Yadong Ding <[email protected]>
imeoer
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCerrors do not affect subsequent conversion tasks, so separategcandconvertbygoroutinego and don't returnerrorinGC.Changes:
goroutine.Ref: Feature request: manage local layer caches #141