Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Nahimic code injection. #99388

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Disable Nahimic code injection. #99388

merged 1 commit into from
Nov 18, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 18, 2024 •
edited by AThousandShips
Loading

Might fix #85608 and fix #13208

Based on KiCad code.

@bruvzg bruvzg added this to the 4.4 milestone Nov 18, 2024
@bruvzg bruvzg requested a review from a team as a code owner November 18, 2024 11:12
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Nov 18, 2024
akien-mga
akien-mga approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be pretty safe, and fix a very confusing and game breaking issue for affected users (including players of Godot games).

mhilbrunner
mhilbrunner approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Makes sense and shouldn't break anything.

@Repiteo Repiteo merged commit cc48a22 into godotengine:master Nov 18, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
bug cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release platform:windows topic:porting
Projects
None yet
Milestone
4.4
4 participants
@bruvzg @Repiteo @mhilbrunner @akien-mga