ItemList highlight selected items and draw cursor-stylebox last
#99361
+50
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Dec 13, 2024
KoBeWi
reviewed
Dec 13, 2024
KoBeWi
approved these changes
Dec 13, 2024
havi05
force-pushed
the
itemlist-hover-on-selected
branch
from
6e46623 to
555ef3d
Compare
I would start a new pull request for the |
|
In a new one. |
havi05
force-pushed
the
itemlist-hover-on-selected
branch
2 times, most recently
from
28e52e5 to
352f907
Compare
|
Added |
havi05
force-pushed
the
itemlist-hover-on-selected
branch
from
352f907 to
97ccf51
Compare
|
Needs rebase after #99355. |
havi05
force-pushed
the
itemlist-hover-on-selected
branch
from
97ccf51 to
b051117
Compare
KoBeWi
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hovered items of an
ItemListare now highlighted even if they are already selected.This fixes godotengine/godot-proposals#7404 by adding two new hover styleboxes to preserve the functionality of the
selectedandselected focusstyleboxes. I've added the new styleboxes to thedefault_theme.cppand to theeditor_theme_manager.cppto add this functionality to the filesystem of the editor.This fixes also the issue that the
cursorstylebox was drawn behind some styleboxes. (See 2. row of images)2024-11-17.16-34-02.mp4
2024-11-17.16-34-57.mp4
Video of Filesystem
2024-11-17.16-36-12_.mp4