-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose EditorUndoRedoManager's clear_history()
#90130
Conversation
b22d8cb
to
d4d187c
Compare
I just realized we have EDIT: |
6643a70
to
4a450bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see the benefit of this at the moment, but it's not exactly "harmful" either.
Clearing history is necessary for operations that do changes to the scene which you can't undo them. Also exposing EditorUndoRedoManager is needed for things like #78355 (currently you need an EditorPlugin to use undoredo) |
e92f36b
to
f2c3c72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
f2c3c72
to
ad7a2d1
Compare
Thanks! |
Exposes
clear_history()
method (I also swapped its arguments, the new order makes more sense).Closes godotengine/godot-proposals#2153
I also exposed EditorUndoRedoManager via EditorInterface, to make it accessible to EditorScripts.