Add move inout point/set offset shortcut to AnimationTrackEditor #85582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shortcuts for easy AudioPlayback positioning and trimming.
setoffset.mp4
[: move in point selection]: move out point selectionCtrl + [: set start offsetCtrl + ]: set end offsetFor now, this provides a simple workaround for the #85088 problem (but does not close fully). Just set the timeline to
0, select the audio track key, and pressCtrl + [, then the workaround should be done.There are a few known issues:
Move out point selection does not take key length into account for AudioTrack/AnimationPlaybackTrack. This has long been a problem with existing operations such as Scale Selection, etc., and would require them to fundamentally change their key length acquisition algorithm.
Set start offset changes the time position of a key, so if the beginning of another AudioTrack key already exists, an error may occur. To implement this correctly, you will need to implement some sort of workaround for existing keys, as is done inside Move Selection. This is a rare case and can be followed up on later.