Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[String] Fix string conversion for -0.0 float values. #81328

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[String] Fix string conversion for -0.0 float values. #81328

merged 1 commit into from
Sep 5, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 5, 2023

Fixes #81317

Replaces > 0 with the proper float sign and abs functions for floats.

@bruvzg bruvzg added this to the 4.2 milestone Sep 5, 2023
@bruvzg bruvzg requested a review from a team as a code owner September 5, 2023 06:33
@dalexeev
Copy link
Member

dalexeev commented Sep 5, 2023

Perhaps a test case should be added?

godot/tests/core/string/test_string.h

Line 639 in 75de1ca

TEST_CASE("[String] sprintf") {

@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 5, 2023
@bruvzg bruvzg requested a review from a team as a code owner September 5, 2023 06:59
@YuriSizov YuriSizov merged commit 95b00b1 into godotengine:master Sep 5, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 21, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

"%+f" % -0.0 evaluates to "+-0.000000" instead of "-0.000000"
5 participants
@bruvzg @dalexeev @YuriSizov @akien-mga @AThousandShips