Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erroneous pad_zeros() warning #79202

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Fix erroneous pad_zeros() warning #79202

merged 1 commit into from
Jul 8, 2023

Conversation

MewPurPur
Copy link
Contributor

Fixes #79195

@MewPurPur MewPurPur requested a review from a team as a code owner July 8, 2023 12:55
@dalexeev dalexeev added bug topic:core regression cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 8, 2023
@dalexeev dalexeev added this to the 4.2 milestone Jul 8, 2023
@dalexeev
Copy link
Member

dalexeev commented Jul 8, 2023

I think it makes sense to add test cases for this.

@MewPurPur MewPurPur force-pushed the fix-pad-zeros-error branch from d216268 to cc5500f Compare July 8, 2023 13:16
@MewPurPur MewPurPur requested a review from a team as a code owner July 8, 2023 13:16
@MewPurPur
Copy link
Contributor Author

Nice idea, doned.

@akien-mga akien-mga changed the title Fix erroneous pad_zeros() warning Fix erroneous pad_zeros() warning Jul 8, 2023
@akien-mga akien-mga merged commit 83cc5d4 into godotengine:master Jul 8, 2023
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the fix-pad-zeros-error branch July 8, 2023 16:39
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

String::pad_zeros regression with padding less digits than length of string
4 participants
@MewPurPur @dalexeev @akien-mga @YuriSizov