Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix external resource ids lost #77749

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Fix external resource ids lost #77749

merged 1 commit into from
Jun 1, 2023

Conversation

RandomShaper
Copy link
Member

Fixes #77172.

@RandomShaper RandomShaper added this to the 4.1 milestone Jun 1, 2023
RedworkDE
RedworkDE approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@RedworkDE RedworkDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change solves the issue and before #74405 it was also local_path so the change probably makes sense as well.

@akien-mga akien-mga merged commit 621d68e into godotengine:master Jun 1, 2023
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_ext_res_id branch June 2, 2023 11:42
@RandomShaper
Copy link
Member Author

I forgot to add that the uids the editor save adds are still lost when re-saving from script. I'm a bit confused about that being expected or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedworkDE RedworkDE RedworkDE approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

All ExtResource ids change after saving (4.1 regression)
3 participants
@RandomShaper @akien-mga @RedworkDE