(Re-)Implemented Light3D's property "shadow_reverse_cull_face" #77238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusneg
force-pushed
the
light-reverse-cull-face
branch
2 times, most recently
from
27d8792 to
989c125
Compare
clayjohn
reviewed
May 19, 2023
servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp
Outdated
Show resolved
Hide resolved
The parameter shadow_reverse_cull_face is now passed to the shadow pass so that the mesh back-faces are used for shadow map calculation.
markusneg
force-pushed
the
light-reverse-cull-face
branch
from
989c125 to
8a3e829
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter "shadow_reverse_cull_face" is now passed to the shadow pass so that the mesh back-faces can be used for shadow map calculation. Fixes #50005.
While in 3.x the "shadow_bias" had to be negative for reversed cull faces, in 4.x it seems to work well with positive values. In contrast, the property "shadow_normal_bias" seems not to be normalized as it makes shadow acne on the back-faces worse.