Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TextServer justification flags to Label, Label3D, TextMesh and RTL. Add flags to control last/single line justification. #75250

Merged
merged 1 commit into from
May 16, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 23, 2023

  • Exposes TextServer justification flags to Label, Label3D, TextMesh (as a property) and RichTextLabel (as a push_paragraph argument and [p justification_flags=...] bbcode tag argument).
  • Adds flags to control last/single line justification.
    • Adds flag to always justify controls with a single line (was always true, default behavior).
    • Adds flag to skip last line when applying justification (was always true, default behavior).
    • Adds flag to skip last line with visible character (skip all extra line breaks / spaces at the end of paragraph) when applying justification (new).

@bruvzg bruvzg added this to the 4.x milestone Mar 23, 2023
@bruvzg bruvzg force-pushed the lbl_rtl_jst_flags branch from 34a6362 to f1d6046 Compare March 28, 2023 08:24
@bruvzg bruvzg marked this pull request as ready for review March 28, 2023 08:49
@bruvzg bruvzg requested review from a team as code owners March 28, 2023 08:49
doc/classes/Label.xml Outdated Show resolved Hide resolved
… RTL. Add flags to control last/single line justification.
@bruvzg bruvzg force-pushed the lbl_rtl_jst_flags branch from f1d6046 to 9163d8c Compare May 15, 2023 16:24
@bruvzg bruvzg requested a review from a team as a code owner May 15, 2023 16:24
@akien-mga akien-mga merged commit 59c19a7 into godotengine:master May 16, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 4.x, 4.1 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants