Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Camera3D gizmo clickable #68003

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Make Camera3D gizmo clickable #68003

merged 1 commit into from
Oct 31, 2022

Conversation

timothyqiu
Copy link
Member

There's currently no way to select the camera in 3D viewport.

This PR makes the gizmo lines clickable.

Peek 2022-10-29 14-01

@timothyqiu timothyqiu added this to the 4.0 milestone Oct 29, 2022
@timothyqiu timothyqiu requested a review from a team as a code owner October 29, 2022 06:04
@fire
Copy link
Member

fire commented Oct 29, 2022

Woah. I like this. Needs a review from the other Godot Engine teams though.

adamscott
adamscott approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me. It's something I needed without knowing it.

@adamscott
Copy link
Member

adamscott commented Oct 29, 2022 •
edited
Loading

I suggest to add the "cherrypick:3.x" tag to this PR.

@akien-mga akien-mga merged commit 4845feb into godotengine:master Oct 31, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 31, 2022
@timothyqiu timothyqiu deleted the camera-gizmo-select branch October 31, 2022 12:10
@timothyqiu
Copy link
Member Author

Cherry-picked for 3.6.

@timothyqiu timothyqiu removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:3d usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timothyqiu @fire @adamscott @akien-mga