Enhance filesystem dock tooltips

[KoBeWi]

Closes godotengine/godot-proposals#175

Added this to the tooltips:

• file size
• resource type (if resource)
• bigger preview (if texture or image)
  

[YeldhamDev]

The borders of the tooltips for images seem broken.

[KoBeWi]

What do you mean?
The bigger tooltip in the GIF just went outside recording area 🙃

[YeldhamDev]

What do you mean?

The left border has a much smaller gap than the rest when hovering images.

[KoBeWi]

Borders are managed by the default tooltip container, so it doesn't seem like my fault. I could maybe hack it by adding an empty control.

[YeldhamDev]

It would be better if we found the root issue rather than implementing a hack. Still, not a stopper for this PR.

[fire-forge]

What do you think about adding previews for more resources there, using the same system the FileSystem uses to get previews in grid mode? That way more resources, like scenes, scripts, gradients, materials, fonts, etc. could have tooltip previews.

[KoBeWi]

I'd leave it for later. The PR lays a nice foundation for such additions.

[groud]

I am not sure the preview implementation is acceptable as loading a resource can be costly. In that case it's only images, but I think I would have preferred that this PR uses the built in resource preview system.

It should even simplify the implementation, as it's fairly easy to use. You can check for uses of EditorResourcePreview::get_singleton()->queue_resource_preview to check how it works.

[KoBeWi]

I tried this

TextureRect *tr = memnew(TextureRect);
EditorResourcePreview::get_singleton()->queue_resource_preview(p_path, tr, "set_texture", Variant());

but it doesn't have effect 🤔

[KoBeWi]

Ok done. It indeed simplified the code, but I still load the texture to display the dimensions 🙃 (it's not possible otherwise)

My idea for possible solution is to add EditorResourcePreview.get_preview_metadata(path, meta_name). The metadata would be automatically stored somewhere in EditorResourcePreview depending on the resource type (e.g. we could store size of textures).

[groud]

Yeah I agree with the fact that EditorResourcePreview could also generate some metadata to be displayed along with the picture or something like that.
If you don't want to implement that right now and maybe to avoid freezes, maybe you could load the texture in the _tooltip_thumbnail_done callback? With some luck the texture will still be kept loaded and it would avoid the loading freeze.

[KoBeWi]

It doesn't work. When the preview is cached it doesn't even load the texture. I can look into implementing preview metadata, but I don't think it really blocks this PR.

[reduz]

All welcome the new Godot Operating System overlord.

[mhilbrunner]

Editor PR review meeting: feature is wanted and approved, @KoBeWi wants to improve texture loading first seperately.

[KoBeWi]

Rebased after #64628. For now this PR still uses the hard-coded approach. I'll look into implementing EditorResourceFileTooltipPlugin.

[KoBeWi]

Ok I added an API for creating resource tooltips and added a plugin for textures. We can add more plugins later (I have some fun idea for audio files).

[akien-mga]

Thanks!