Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Allow negative scale in Particles and CPUParticles #53852

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 15, 2021

This can be used to make 2D particles look more 3D-y with thoughtful use of scale curve animation.

Negative scale is already allowed in master following the per-axis particle scale changes. Therefore, this PR is only relevant for 3.x. The zero scale workaround was taken from the master branch's ParticlesMaterial.

This closes #41587.

@Calinou Calinou requested review from a team as code owners October 15, 2021 16:39
@Calinou Calinou added this to the 3.4 milestone Oct 15, 2021
@Calinou Calinou force-pushed the particles-allow-negative-scale branch from a107a27 to bdb8c96 Compare October 15, 2021 16:43
This can be used to make 2D particles look more 3D-y with thoughtful use
of scale curve animation.
@Calinou Calinou force-pushed the particles-allow-negative-scale branch from bdb8c96 to c4a3560 Compare October 15, 2021 17:06
@akien-mga akien-mga modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga force-pushed the 3.x branch 2 times, most recently from 71cb8d3 to c58391c Compare January 6, 2022 22:40
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 3, 2022
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, though too late for 3.5, but we can give it a try for 3.6-beta1.
Would be good to have a confirmation from @godotengine/rendering folks that this is safe enough.

@clayjohn
Copy link
Member

clayjohn commented Jul 4, 2022

I think this is probably safe enough. We still have issues with negative scaling (particularly as it scales normals and users don't expect that, see: #29317 and #47984) but for most situations it works fine.

@akien-mga akien-mga merged commit 906a693 into godotengine:3.x Aug 5, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Aug 5, 2022
@Calinou Calinou deleted the particles-allow-negative-scale branch August 6, 2022 03:19
@akien-mga akien-mga changed the title Allow negative scale in Particles and CPUParticles [3.x] Allow negative scale in Particles and CPUParticles Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants