-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Allow negative scale in Particles and CPUParticles #53852
Merged
akien-mga
merged 1 commit into
godotengine:3.x
from
Calinou:particles-allow-negative-scale
Aug 5, 2022
Merged
[3.x] Allow negative scale in Particles and CPUParticles #53852
akien-mga
merged 1 commit into
godotengine:3.x
from
Calinou:particles-allow-negative-scale
Aug 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
particles-allow-negative-scale
branch
from
October 15, 2021 16:43
a107a27
to
bdb8c96
Compare
akien-mga
reviewed
Oct 15, 2021
This can be used to make 2D particles look more 3D-y with thoughtful use of scale curve animation.
Calinou
force-pushed
the
particles-allow-negative-scale
branch
from
October 15, 2021 17:06
bdb8c96
to
c4a3560
Compare
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
January 6, 2022 22:40
71cb8d3
to
c58391c
Compare
akien-mga
approved these changes
Jul 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, though too late for 3.5, but we can give it a try for 3.6-beta1.
Would be good to have a confirmation from @godotengine/rendering folks that this is safe enough.
Thanks! |
akien-mga
changed the title
Allow negative scale in Particles and CPUParticles
[3.x] Allow negative scale in Particles and CPUParticles
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to make 2D particles look more 3D-y with thoughtful use of scale curve animation.
Negative scale is already allowed in
master
following the per-axis particle scale changes. Therefore, this PR is only relevant for3.x
. The zero scale workaround was taken from themaster
branch's ParticlesMaterial.This closes #41587.