-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document editor import options in the class reference #49524
Document editor import options in the class reference #49524
Conversation
09f65f0
to
6694a9e
Compare
This would be good to salvage, but it likely got a bit more complicated with the new importer. |
I think this can be improved by properly overriding |
6694a9e
to
65f84b9
Compare
Updated to improve the hack and make it work for all The old docs for |
<member name="_subresources" type="Dictionary" setter="" getter="" default="null"> | ||
</member> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to check if this should be renamed or hidden.
<member name="compress" type="bool" setter="" getter="" default="null"> | ||
</member> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default values don't seem to be included properly, yet they're seen as "valid" so it shows default="null"
for all (unlike e.g. EditorSettings where it doesn't show default
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a second commit that solves this by calling get_import_options
directly from DocTools so we can have access to the default value in ImportOption
. It's a bit more hacky though. 09f0f70d81f50f7740268bcba4aff2106a9ec8cd
The less hacky option would be to properly register import options as properties in ClassDB with their default values, and then we don't need any of these hacks.
This would be nice to have, but seems to be in need of extra work. I'm kicking it to 4.x, but hoping that we can merge it in 4.0. |
Tooltips are displayed when hovering import options, both in the Import dock and in the import defaults editor (which is in the Project Settings). Co-authored-by: Rémi Verschelde <[email protected]>
09f0f70
to
8352122
Compare
Rebased and tested again, it works as expected. Descriptions still need to be filled out, but the editor display works correctly. Note that Advanced Import Settings options don't have a XML generated for yet. This should be tackled in a separate PR, as it's likely quite complex to get right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We can merge after 4.1 is released and document all this for 4.2.
It's still a draft, anything major still pending?
No, I forgot to mark it as ready for review. I just did that 🙂 |
Should we change the title and the commit message to something different? Objectively, this doesn't actually document much, but it allows for these options to be documented. We don't want to have misleading information in changelogs :) |
Uhm, I think I got distracted and merged it anyway :D Welp, no matter now. Thanks! |
I'm starting work on documenting all import options – it shouldn't take too long before I open a PR with filled descriptions. Edit: Done: #79405 |
Tooltips are displayed when hovering import options, both in the Import dock and in the import defaults editor (which is in the Project Settings).
This closes godotengine/godot-proposals#2041. See also #48548 and #49525 (can be merged independently).
Preview
Disregard the black text – it's not a bug related to this PR.
Import dock
Import defaults editor
TODO