Add an import setting use_legacy_names for 3.3 compatibility. #48058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of 3.3, internationalization features were added to allow arbitrary bone and node names.
However, doing so will break all references and existing animation clips for projects upgraded from 3.2
This adds an import setting, enabled by default, but disabled for newly generated .import files which restores the old behavior.
This addresses issue #47977.
PR #47742 was recently merged, but is insufficient to cover the whole issue. I made that PR part of the use_legacy_names import setting introduced in this change.
This commit effectively reverts the three commits f1e8ec9 and b032067 and 1f87bca behind the use_legacy_names import setting.
CC @fire @akien-mga
A new fairly comprehensive test project generated from 3.2.3 is here:
BoneSanitizationFixed.zip
based on the following model:
https://github.com/godotengine/godot-tests/blob/master/tests/blend_export/gltf/45545-relax-name-sanitization.gltf
Includes scene node references, cross-scene animation references and other fun cases.
Old version of test project is here: BoneSanitization.zip Apparently some changes were made in October so this project has bone names with "." in them which was not allowed in 3.2.3