-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable lights for objects with baked lighting #41629
Conversation
194dc42
to
239298b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks great! Just make sure to fill in all the docs before it is merged.
Looks good to me too (with clayjohn's amendments)! 😄 👍 |
239298b
to
bde405f
Compare
Updated the PR to add more docs. If the added docs are fine, this should be good to merge for 3.2.4 :) |
Don't apply lighting to objects when they have a lightmap texture and the light is set to BAKE_ALL. This prevents applying the same direct light twice on the same object and makes setting up scenes with mixed lighting much easier.
bde405f
to
fcb00ca
Compare
For the sake of consistency I'll report that DirectionalLights still double illuminate backed objects, even wen setup to Bake Mode All. But I can already work with this, great enhancement! I can open a bug report if you want to track it there. |
It sounds like a bug to me. I think it'd be worth reporting it. |
@Janders1800 Can you still reproduce this DirectionalLight issue in 3.2.4beta6? |
No, it seems to work OK |
@Janders1800 Actually, I was able to reproduce this since I last commented: Try making the DirectionalLight visible in main scene included in the above project. |
Weird, I can reproduce on your project but in mine works ok. |
@Janders1800 Looking at your test project, it seems this feature works as expected in GLES2 but not GLES3. I'll open a new issue about this. |
Don't apply lighting to objects when they have a lightmap texture and the light is set to BAKE_ALL. This prevents applying the same direct light twice on the same object and makes setting up scenes with mixed lighting much easier.
Addresses godotengine/godot-proposals#1306.