Use enums for requesting permissions

[j20001970]

Use enumeration for requesting permission instead of strings.

This is breaking changes, as the method signatures are different.

The default path of requestPermission(String permissionName, Activity activity) in PermissionUtil.java for Android will become unreachable.

[j20001970]

Returning accessible folders from a permission related method on macOS doesn't feel quite match up, so I removed it. Is such functionality still relevant?

[bruvzg]

It is related to permissions, it is a list of folders access permissions were granted for. It's definitely should not be removed, since it's the only way to know if you still have permission to access the folder (or need to ask the user to grant it again).

[j20001970]

Having different behaviours on the same method feels quite strange...

Will moving it to other class like DirAccess help?

[bruvzg]

In case of Android, it seems like you can use this functions to requires any arbitrary permission, not just one from the list, so change it to enum is likely completely wrong.

[j20001970]

In case of Android, it seems like you can use this functions to requires any arbitrary permission, not just one from the list, so change it to enum is likely completely wrong.

The change was made with bringing support to other OSes in future in mind.

It is indeed that the capability of requesting arbitrary permission on Android will be lost, but it has limited use if Godot cannot access what it request permissions for without a plugin (bluetooth, location comes to the mind in the case of Android), and said plugin should already have ways to request permissions for what it is trying to access, without relying on Godot code in the first place.

Of course there might be other ways to achieve cross-platform permission requests without breaking the ability of doing platform-specific (like string constants from what I can think of, but haven't found other classes doing that).