Derive stringly and numeric ToVariant for fieldless enums #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
feature
chitoyuu
force-pushed
the
feature/primitive-enum
branch
from
3d59022 to
63fcc2e
Compare
Adds the `#[variant(enum = "repr")]` and `#[variant(enum = "str")]` item-level attribute to the Variant conversion derive macros for fieldless enums. - `#[variant(enum = "repr")]` - convert through the numeric type specified using `#[repr]`. - `#[variant(enum = "str")]` - convert through string representations of the variant names. Close godot-rust#546.
chitoyuu
force-pushed
the
feature/primitive-enum
branch
from
63fcc2e to
3fb94a2
Compare
chitoyuu
changed the title
|
Should be ready for review now! |
|
Thanks a lot for this! Maybe a small request for the future: if you have a refactoring in the same PR (here splitting I also seems like the documentation for bors r+ |
|
Build succeeded: |
|
Ah yes, thanks for reminding me! Got a bit lazy with the rebase here. I'll make a PR for the docs later. |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2022
971: Add docs for the `#[variant(enum)]` attribute. r=Bromeon a=chitoyuu Follow-up to #964 Co-authored-by: Chitose Yuuzaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
#[variant(enum = "repr")]and#[variant(enum = "str")]item-level attribute to the Variant conversion derive macros for fieldless enums.#[variant(enum = "repr")]- convert through the numeric type specified using#[repr].#[variant(enum = "str")]- convert through string representations of the variant names.Close #546.